New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use responseType
instead of options.encoding
to get a Buffer
#940
Conversation
Can you add a test to ensure |
You need to remove the |
You also need to update:
|
I think we should throw if |
Full list of breaking changes listed here. https://github.com/sindresorhus/got/releases/tag/v10.0.0 One breaking change affected our usage: "Use the responseType option instead of encoding to get a Buffer" sindresorhus/got#940 - got(…, {encoding: null}); + got(…, {responseType: 'buffer'});
Full list of breaking changes listed here. https://github.com/sindresorhus/got/releases/tag/v10.0.0 One breaking change affected our usage: "Use the responseType option instead of encoding to get a Buffer" sindresorhus/got#940 - got(…, {encoding: null}); + got(…, {responseType: 'buffer'});
Full list of breaking changes listed here. https://github.com/sindresorhus/got/releases/tag/v10.0.0 One breaking change affected our usage: "Use the responseType option instead of encoding to get a Buffer" sindresorhus/got#940 - got(…, {encoding: null}); + got(…, {responseType: 'buffer'});
#921 (comment)
Checklist