Make URLSearchParams mergeable #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Feb 21, 2019
| let searchParams; | ||
| let {searchParams} = options; | ||
| delete options.searchParams; | ||
|
|
There was a problem hiding this comment.
Moved from the lasting if. Just a more readable code, behavior is the same.
szmarczak
commented
Feb 21, 2019
| methods: new Set(), | ||
| statusCodes: new Set(), | ||
| errorCodes: new Set(), | ||
| maxRetryAfter: undefined |
There was a problem hiding this comment.
Performance nitpick.
szmarczak
commented
Feb 21, 2019
| @@ -77,7 +78,7 @@ const preNormalize = (options, defaults) => { | |||
| } | |||
| } | |||
|
|
|||
| if (options.gotTimeout) { | |||
| if (!options.retry.maxRetryAfter && options.gotTimeout) { | |||
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718
Checklist