Add beforeError hook

[szmarczak]

Fixes https://github.com/sindresorhus/gh-got/blob/master/index.js

Instead using handler we could do:

hooks: {
	beforeRequest: [
		options => {
			if (options.token) {
				options.headers.authorization = options.headers.authorization || `token ${options.token}`;
			}
		}
	],
	afterResponse: [
		response => {
			response.rateLimit = getRateLimit(response);
			return response;
		}
	],
	onError: [
		error => {
			const {response} = error;

			if (response && response.body) {
				error.name = 'GitHubError';
				error.message = `${response.body.message} (${error.statusCode})`;
			}

			if (response) {
				error.rateLimit = getRateLimit(response);
			}

			return error;
		}
	]
}

Checklist

• I have read the documentation.
• I have included a pull request description of my changes.
• I have included some tests.
• If it's a new feature, I have included documentation updates.

[sindresorhus]

Fixes sindresorhus/gh-got:index.js@master

I wouldn't say it fixes that issue. This just works around it. We still need to properly fix handler.

[sindresorhus]

Does the hook catch absolutely all errors? If not, it should be documented what it doesn't catch. For example, I don't think it currently catches input validation errors (Neither should it IMHO).

[sindresorhus]

Wouldn't beforeError be a more correct name for this?

[szmarczak]

I wouldn't say it fixes that issue. This just works around it. We still need to properly fix handler.

True. But it's not that easy, it will take a while to solve it :P

Does the hook catch absolutely all errors? If not, it should be documented what it doesn't catch. For example, I don't think it currently catches input validation errors (Neither should it IMHO).

You're right. I'll document that.

Wouldn't beforeError be a more correct name for this?

I have been still considering this. You just nailed it :) Will change that.

[sindresorhus]

Can you fix the merge conflict?

[szmarczak]

done