Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge hooks on got.extend() #608

Merged
merged 2 commits into from Sep 10, 2018
Merged

Merge hooks on got.extend() #608

merged 2 commits into from Sep 10, 2018

Conversation

szmarczak
Copy link
Collaborator

Fixes #606

@szmarczak szmarczak mentioned this pull request Sep 8, 2018
Closed
@brandon93s
Copy link
Contributor

What makes this preferable to #607?

@szmarczak
Copy link
Collaborator Author

What makes this preferable to #607?

My previous answer:

This is nonsense.

got calls normalizeArguments, where options are merged.

So that PR didn't change anything. This does.

@brandon93s
Copy link
Contributor

Ah, I missed the file delete from the diff originally, making this change look larger than it is.

Mind adding tests to cover what this fixes?

@szmarczak
Copy link
Collaborator Author

No worries. Done :D

@sindresorhus sindresorhus merged commit 292f78a into sindresorhus:master Sep 10, 2018
@szmarczak szmarczak deleted the merging-hooks-fix branch January 17, 2019 18:55
@fnky fnky mentioned this pull request Jan 28, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szmarczak @brandon93s @sindresorhus