Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage in the readme examples #1203

Merged
merged 2 commits into from Apr 27, 2020
Merged

Fix incorrect usage in the readme examples #1203

merged 2 commits into from Apr 27, 2020

Conversation

PopGoesTheWza
Copy link
Contributor

@PopGoesTheWza PopGoesTheWza commented Apr 27, 2020

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

- add JSON example to *Usage* section #1156
- add description for `.paginate.all()` #1198
- fix sample code under *Proxies*
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@szmarczak
Copy link
Collaborator

Nice work 🙌 I left some hints. Thanks for contributing!

@szmarczak szmarczak changed the title docs: address some open issues Fix incorrect usage in the readme examples Apr 27, 2020
@PopGoesTheWza
Copy link
Contributor Author

Aye aye, Sir.

@szmarczak szmarczak merged commit 16ff82f into sindresorhus:master Apr 27, 2020
@PopGoesTheWza PopGoesTheWza deleted the documentation branch April 27, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants