Limit number of requests in pagination #1181
Conversation
readme.md
Outdated
| ###### pagination.requestLimit | ||
|
|
||
| Type: `number`\ | ||
| Default: `100` |
There was a problem hiding this comment.
Why 100? If this is just meant to prevent a mistake in development, I think the default should be higher. Maybe just Infinity. Then you just set it if you need it.
There was a problem hiding this comment.
Okay, I increased it to 10000. Defaulting to Infinity is too much I think as also at runtime in production you could trigger accidentally an infinite amount.
readme.md
Outdated
| Type: `number`\ | ||
| Default: `100` | ||
|
|
||
| The maximum amount of request that should be triggered. |
There was a problem hiding this comment.
The text should include the intended use-case for this option.
There was a problem hiding this comment.
I just updated the paragraph with an example.
There was a problem hiding this comment.
It should be noted that retry requests does not count.
There was a problem hiding this comment.
Just added that note as well.
readme.md
Outdated
|
|
||
| The maximum amount of request that should be triggered. [Retries on failure](#retry) are not count towards this limit. | ||
|
|
||
| For example, if you need the first 10 pages but don't know how many items there are per page. It can also be helpful during development to avoid an infinite number of requests. |
There was a problem hiding this comment.
For example, if you need the first 10 pages but don't know how many items there are per page.
It's not clear how setting a request limit helps with this? It seems like setting a hard-coded limit goes against not knowing how many items there are.
There was a problem hiding this comment.
are not count -> are not counted
There was a problem hiding this comment.
@szmarczak it's fixed.
sindresorhus
changed the title
Currently, it's easily possible to trigger an infinite amount of requests during development because we use a
while(true)construct. This PR adds a new option to limit the number of requests.Checklist