Test responseType set to undefined

Fixes #1252
sindresorhus · May 12, 2020 · 0e8582f · 0e8582f
1 parent 9b04963
commit 0e8582f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/source/as-promise/core.ts b/source/as-promise/core.ts
@@ -57,6 +57,12 @@ export default class PromisableRequest extends Request {
 		assert.any([is.boolean, is.undefined], options.resolveBodyOnly);
 		assert.any([is.boolean, is.undefined], options.methodRewriting);
 		assert.any([is.boolean, is.undefined], options.isStream);
+		assert.any([is.string, is.undefined], options.responseType);
+
+		// `options.responseType`
+		if (options.responseType === undefined) {
+			options.responseType = 'text';
+		}
 
 		// `options.retry`
 		const {retry} = options;

diff --git a/source/core/index.ts b/source/core/index.ts
@@ -624,6 +624,7 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 		assert.any([is.boolean, is.undefined], options.http2);
 		assert.any([is.boolean, is.undefined], options.allowGetBody);
 		assert.any([is.boolean, is.undefined], options.rejectUnauthorized);
+		assert.any([is.string, is.undefined], options.localAddress);
 
 		// `options.method`
 		if (is.string(options.method)) {

diff --git a/test/response-parse.ts b/test/response-parse.ts
@@ -44,6 +44,12 @@ test('Text response', withServer, async (t, server, got) => {
 	t.is((await got({responseType: 'text'})).body, jsonResponse);
 });
 
+test('Text response #2', withServer, async (t, server, got) => {
+	server.get('/', defaultHandler);
+
+	t.is((await got({responseType: undefined})).body, jsonResponse);
+});
+
 test('JSON response - promise.json()', withServer, async (t, server, got) => {
 	server.get('/', defaultHandler);