Add support for orf, arw, dng, and nef RAW image types #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're adding support for a new file type, please follow the below steps:
I'd love to do that, but each branch will conflict with each other, as the edits to
index.js
are in the same spot (between cr2 and tiff detection, due to the common 0x49 0x49 prefix). I hope this PR is banal enough to batch these together.fixture.<extension>
to thefixture
directory.Done. I ran
truncate -s 128
on each fixture (as we only need the first 8 bytes to run the tests, and originals contained serial numbers, GPS location, and other potentially private metadata).types
array intest.js
.Done.
index.js
file.Done.
FileType
type inindex.d.ts
.Done.
Supported file types
section in the readme, in the format- [`<extension>`](URL) - Format name
, for example,- [`png`](https://en.wikipedia.org/wiki/Portable_Network_Graphics) - Portable Network Graphics
Done.
keywords
array in thepackage.json
file.Done.
Run
$ npm test
to ensure the tests pass.402 tests passed
Open a pull request with a title like
Add support for Format
, for example,Add support for PNG
.The pull request description should include a link to the official page of the file format or some other source. Also include a link to where you found the file type detection / magic bytes and the MIME type.
The mime types agree with the output of exiftool.