Fix histogram scrape performance (#219)

Fixes #216
siimon · Sep 19, 2018 · 45e0c3e · 45e0c3e
1 parent 6a71f47
commit 45e0c3e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Allow setting Gauge values to NaN, +Inf, and -Inf
+- Fixed `histogram` scrape performance by using `acc.push` instead of `acc.concat`. Fixes #216 with #219
 
 ### Added
 

diff --git a/lib/histogram.js b/lib/histogram.js
@@ -288,7 +288,7 @@ function extractBucketValuesForExport(histogram) {
 
 function addSumAndCountForExport(histogram) {
 	return (acc, d) => {
-		acc = acc.concat(d.buckets);
+		acc.push(...d.buckets);
 
 		const infLabel = Object.assign({ le: '+Inf' }, d.data.labels);
 		acc.push(