Merge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual

fix error message for aboveOrEqual & belowOrEqual
shouldjs · Apr 19, 2017 · 8114b5d · 8114b5d
2 parents 031888e + 02ec6a0
commit 8114b5d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/ext/number.js b/lib/ext/number.js
@@ -136,7 +136,7 @@ export default function(should, Assertion) {
    * (10).should.be.aboveOrEqual(10);
    */
   Assertion.add('aboveOrEqual', function(n, description) {
-    this.params = { operator: 'to be above or equal' + n, message: description };
+    this.params = { operator: 'to be above or equal ' + n, message: description };
 
     this.assert(this.obj >= n);
   });
@@ -156,7 +156,7 @@ export default function(should, Assertion) {
    * (0).should.be.belowOrEqual(0);
    */
   Assertion.add('belowOrEqual', function(n, description) {
-    this.params = { operator: 'to be below or equal' + n, message: description };
+    this.params = { operator: 'to be below or equal ' + n, message: description };
 
     this.assert(this.obj <= n);
   });

diff --git a/test/ext/number.test.js b/test/ext/number.test.js
@@ -129,11 +129,19 @@ describe('number', function() {
     (5).should.be.aboveOrEqual(2);
     (5).should.be.aboveOrEqual(5);
     (5).should.not.be.aboveOrEqual(6);
+
+    err(function() {
+      (5).should.be.aboveOrEqual(6);
+    }, 'expected 5 to be above or equal 6');
   });
 
   it('test belowOrEqual(n)', function() {
     (2).should.be.belowOrEqual(5);
     (5).should.be.belowOrEqual(5);
     (6).should.not.be.belowOrEqual(5);
+
+    err(function() {
+      (6).should.be.belowOrEqual(5);
+    }, 'expected 6 to be below or equal 5');
   });
 });