Merge pull request #159 from shouldjs/fix-157

Fix #157
shouldjs · Oct 28, 2017 · 1e7b1d0 · 1e7b1d0
2 parents ff0877a + 6a7989f
commit 1e7b1d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/ext/contain.js b/lib/ext/contain.js
@@ -138,7 +138,7 @@ export default function(should, Assertion) {
     this.params = { operator: "to contain " + i(other) };
 
     var obj = this.obj;
-    if (typeof obj == "string") {
+    if (typeof obj === "string" && typeof other === "string") {
       // expect other to be string
       this.is.equal(String(other));
     } else if (isIterable(obj) && isIterable(other)) {

diff --git a/test/ext/contain.test.js b/test/ext/contain.test.js
@@ -54,6 +54,7 @@ describe("contain*", function() {
     [1, 2, 3].should.containDeep([3, 2]);
 
     ["code-for-days", "code"].should.containDeep(["code", "code-for-days"]);
+    ({ a: "hello" }.should.not.containDeep({ a: ["hello"] }));
     ["code-for-days", "code-fast"].should.containDeep(["code-fast", "code-for-days"]);
 
     err(function() {