chore(eslint): use words instead of numbers #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslint rules can be configured either using words or number values: * "off" or 0 * "warn" or 1 * "error" or 2 This switches our config to use the string values instead of the number values, since the number values are too cryptic. No change to our actual settings.
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 95.51% 95.51%
=======================================
Files 34 34
Lines 1272 1272
=======================================
Hits 1215 1215
Misses 57 57Continue to review full report at Codecov.
|
freitagbr
approved these changes
Oct 31, 2017
|
LGTM |
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint rules can be configured either using words or number values:
This switches our config to use the string values instead of the number
values, since the number values are too cryptic.
No change to our actual settings.