Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap fs.statSync and fs.lstatSync #783

Merged
merged 2 commits into from Oct 18, 2017
Merged

Wrap fs.statSync and fs.lstatSync #783

merged 2 commits into from Oct 18, 2017

Conversation

freitagbr
Copy link
Contributor

Fixes #745

Adds two new methods to src/common.js, common.statFollowLinks and common.statNoFollowLinks, which wrap fs.statSync and fs.lstatSync, respectively. This change is meant to improve readability and clarify intent.

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #783 into master will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #783      +/-   ##
=========================================
+ Coverage   95.39%   95.4%   +<.01%     
=========================================
  Files          33      33              
  Lines        1239    1241       +2     
=========================================
+ Hits         1182    1184       +2     
  Misses         57      57
Impacted Files Coverage Δ
src/sort.js 96.96% <100%> (ø) ⬆️
src/uniq.js 100% <100%> (ø) ⬆️
src/test.js 95.23% <100%> (ø) ⬆️
src/common.js 98.33% <100%> (+0.03%) ⬆️
src/head.js 100% <100%> (ø) ⬆️
src/ln.js 96.87% <100%> (ø) ⬆️
src/cat.js 100% <100%> (ø) ⬆️
src/tempdir.js 100% <100%> (ø) ⬆️
src/touch.js 100% <100%> (ø) ⬆️
src/mv.js 97.77% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea0e58...8b507d0. Read the comment docs.

Copy link
Member

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any noticeable performance hit by adding an extra function call?

@freitagbr
Copy link
Contributor Author

It's doubtful. I think V8 will just inline the functions anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants