Safely exit by throwing an error

[freitagbr]

Fixes #483.

Instead of exiting the process with process.exit(1), simply throw an error. This way, the error can be caught by Node itself. If the error is not caught, the error is still printed, and the process exits with a 1.

[nfischer]

Is there a way to make the message be part of the new stack trace? That would be even better.

[freitagbr]

Do you mean the 'ShellJS: internal error' message?

[nfischer]

Do you mean the 'ShellJS: internal error' message?

Yeah, that's what I meant

[nfischer]

@freitagbr is it standard to prepend to the message like that?

[freitagbr]

Probably not, so I will suggest a different option: changing the error name to ShellJSInternalError, rather than fiddling with the message itself.

[nfischer]

@freitagbr that could work

[freitagbr]

I toyed around with the idea of creating an internal error class, but in this instance, I think just changing the name should suffice.

[nfischer]

LGTM. Moving this to the dev branch since it's a breaking change.

Hopefully we don't have to worry about unexpected scenarios where you can't assign to properties of exception is caught. This approach should be perfectly fine for any real exception.

[nfischer]

@freitagbr it looks like we may have lost this commit on dev branch with a force push (I wish github supported auto merging). I'll just stick with manual merges instead of rebases to update dev branch.

Would you be able to redo this commit?

[freitagbr]

Yeah, let me do redo this.