Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage for exec() #742

Closed
nfischer opened this issue Jun 18, 2017 · 0 comments
Closed

Improve coverage for exec() #742

nfischer opened this issue Jun 18, 2017 · 0 comments
Assignees
@nfischer
Labels
test coverage

Comments

@nfischer
Copy link
Member

nfischer commented Jun 18, 2017 •
edited

See the coverage report

We're currently missing line coverage for:

Blocks #671
@nfischer nfischer self-assigned this Jun 18, 2017
nfischer added a commit that referenced this issue Jun 18, 2017
@nfischer
test(exec): add tests for coverage
383574b 
No logic change.

This adds one test to cover some missing lines, and adds some `istanbul ignore`
directives.

I see 100% line coverage for `src/exec.js` when running:

```sh
$ nyc --reporter=text --reporter=lcov ava --serial test/exec.js`
```

Fixes #742
@nfischer nfischer mentioned this issue Jun 18, 2017
Merged
nfischer added a commit that referenced this issue Jun 18, 2017
@nfischer
test(exec): add tests for coverage (#744)
5823ab1 
* test(exec): add tests for coverage

No logic change.

This adds one test to cover some missing lines, and adds some `istanbul ignore`
directives.

I see 100% line coverage for `src/exec.js` when running:

```sh
$ nyc --reporter=text --reporter=lcov ava --serial test/exec.js`
```

Fixes #742

* Fix lint
@nfischer nfischer mentioned this issue Jun 18, 2017
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Mar 19, 2018
Closed
@snyk-bot snyk-bot mentioned this issue Aug 13, 2019
Open
This was referenced Aug 29, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 19, 2019
Open
@snyk-bot snyk-bot mentioned this issue Nov 29, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
This was referenced Mar 24, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Open
This was referenced Apr 24, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfischer nfischer

Labels
test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfischer