Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of custom resource lambda zip #7684

Merged
merged 1 commit into from
May 7, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented May 7, 2020

In case of custom resource lambda packaging process being stopped in a middle, we were left with broken zip that was accepted for further deployment.

Fix is to generate zip to temporary directory and move it once generation of archive is finalized

Closes: #7242

So far in case of packaging process being stopped in a middle, we were left with broken zip that was accepted for further deployment.

FIx is to generate zip to temporary directory and move it once generation of archive is finalized
@codecov-io
Copy link

Codecov Report

Merging #7684 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7684      +/-   ##
==========================================
- Coverage   88.01%   88.01%   -0.01%     
==========================================
  Files         245      245              
  Lines        9213     9225      +12     
==========================================
+ Hits         8109     8119      +10     
- Misses       1104     1106       +2     
Impacted Files Coverage Δ
lib/plugins/aws/customResources/generateZip.js 90.00% <100.00%> (+1.11%) ⬆️
.../compile/events/apiGateway/lib/hack/updateStage.js 95.54% <0.00%> (-1.09%) ⬇️
...plugins/aws/package/compile/events/stream/index.js 98.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad7bd3...3649bd2. Read the comment docs.

@medikoo medikoo merged commit 6b3a789 into master May 7, 2020
@medikoo medikoo deleted the 0507-improve-custom-resource-lambda-zip-generation branch May 7, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless Error: Could not unzip uploaded file
2 participants