Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda provisioned concurrency setup #7045

Merged
merged 2 commits into from Dec 4, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 4, 2019

When testing locally it now, when it's available, I've realized it was not setup properly, and that it should be setup on AWS::Lambda::Version resource.

Having that patch in, I've successfully deployed new lambdas with provisioned concurrency setup.
However I observed Internal error CF stack udpate crashes when trying to update already deployed lambdas with that config (This looks as AWS issue, which I discuss with them over email)

@medikoo medikoo added the bug label Dec 4, 2019
@medikoo medikoo added this to the 1.59.0 milestone Dec 4, 2019
@medikoo medikoo self-assigned this Dec 4, 2019
@medikoo medikoo requested a review from pmuens December 4, 2019 10:26
@codecov-io
Copy link

Codecov Report

Merging #7045 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7045      +/-   ##
==========================================
- Coverage    88.5%   88.49%   -0.02%     
==========================================
  Files         230      230              
  Lines        8473     8473              
==========================================
- Hits         7499     7498       -1     
- Misses        974      975       +1
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/functions/index.js 95.83% <83.33%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1cee3...1cf29ff. Read the comment docs.

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM :shipit:

@medikoo medikoo merged commit 0bc5014 into master Dec 4, 2019
@medikoo medikoo deleted the lambda-provisioned-concurrency branch December 4, 2019 11:17
@shaheer-k
Copy link

The issue still seems to be there with the new version (1.59.3). Every deployment is creating additional provisioned concurrenies. I have set versionFunctions: false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants