Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of user configured APIGW #7039

Merged
merged 3 commits into from Dec 3, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 3, 2019

Fixes: #7036

Test was invalid, hence it wasn't picked earlier

@medikoo medikoo added this to the 1.59.0 milestone Dec 3, 2019
@medikoo medikoo self-assigned this Dec 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #7039 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7039   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         230      230           
  Lines        8453     8453           
=======================================
  Hits         7480     7480           
  Misses        973      973
Impacted Files Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js 95.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd76e7e...ad59d22. Read the comment docs.

@medikoo medikoo requested a review from pmuens December 3, 2019 13:17
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. The change makes sense... LGTM :shipit:

@medikoo medikoo merged commit 44115aa into master Dec 3, 2019
@medikoo medikoo deleted the fix-custom-rest-api-id-handling branch December 3, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot activate API gateway logs for shared API gateway
3 participants