Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API GW stage settings only when explicitly set #7033

Merged
merged 3 commits into from Dec 3, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 2, 2019

Fixes #6165

If given APIGW stage parameter is not explicitly set in configuration, then it should not be updated by deployment.

@medikoo medikoo added this to the 1.59.0 milestone Dec 2, 2019
@medikoo medikoo self-assigned this Dec 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #7033 into master will decrease coverage by <.01%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7033      +/-   ##
==========================================
- Coverage    88.5%   88.49%   -0.01%     
==========================================
  Files         229      229              
  Lines        8428     8433       +5     
==========================================
+ Hits         7459     7463       +4     
- Misses        969      970       +1
Impacted Files Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js 95.86% <84%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd93739...4efa19e. Read the comment docs.

@medikoo medikoo marked this pull request as ready for review December 2, 2019 16:29
@medikoo medikoo requested a review from pmuens December 2, 2019 16:30
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked through the code. Looks good (haven't tested it manually, though)...

LGTM :shipit:

@medikoo
Copy link
Contributor Author

medikoo commented Dec 3, 2019

Just looked through the code. Looks good (haven't tested it manually, though)...

I've run all integration tests against it to confirm, all passed well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverless 1.42.x unsets api gateway logging level on previously existing deployment
3 participants