Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS SQS event docs regarding FIFO queue trigger for Lambda #7029

Merged
merged 1 commit into from Nov 30, 2019

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Nov 29, 2019

What did you implement

Update SQS event docs regarding AWS support for triggering a Lambda function from an SQS FIFO queue.

Closes #7023

How can we verify it

See AWS documentation for SQS.

Todos

None.

Useful Scripts
  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Update SQS event docs regarding AWS support for triggering a Lambda function from an SQS FIFO queue.

closes serverless#7023
@codecov-io
Copy link

Codecov Report

Merging #7029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7029   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files         229      229           
  Lines        8418     8418           
=======================================
  Hits         7449     7449           
  Misses        969      969

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d2d00...f3800de. Read the comment docs.

@medikoo medikoo added this to the 1.59.0 milestone Nov 30, 2019
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @faheel

@medikoo medikoo merged commit 6c8cf4c into serverless:master Nov 30, 2019
@faheel faheel deleted the patch-1 branch November 30, 2019 15:29
Copy link

@thetumper thetumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With AWS now supporting FIFO queues as event sources, is serverless also already supporting that?

@faheel
Copy link
Contributor Author

faheel commented Dec 10, 2019

@thetumper Yes, Serverless already supports this since it never imposed this restriction - it was a feature missing from AWS. I'm currently using it in production and it works flawlessly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs regarding AWS support for triggering a Lambda function from an SQS FIFO queue
5 participants