Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ParallelizationFactor prop for Kinesis Streams #7024

Merged
merged 2 commits into from Nov 28, 2019

Conversation

michael-ar
Copy link
Contributor

What did you implement

Exposed the new ParallelizationFactor prop for Kinesis Streams.

Closes #7019

How can we verify it

This config should default the ParallelizationFactor to 1:

functions:
  preprocess:
    handler: handler.preprocess
    events:
      - stream:
          arn: arn:aws:kinesis:region:XXXXXX:stream/foo

This config should set the ParallelizationFactor to 10:

functions:
  preprocess:
    handler: handler.preprocess
    events:
      - stream:
          arn: arn:aws:kinesis:region:XXXXXX:stream/foo
          parallelizationFactor: 10
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo medikoo added this to the 1.59.0 milestone Nov 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #7024 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
+ Coverage   88.48%   88.48%   +<.01%     
==========================================
  Files         229      229              
  Lines        8416     8418       +2     
==========================================
+ Hits         7447     7449       +2     
  Misses        969      969
Impacted Files Coverage Δ
...plugins/aws/package/compile/events/stream/index.js 98.78% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a486d...396f7df. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Thank you @michael-ar !

@medikoo medikoo merged commit f1d2d00 into serverless:master Nov 28, 2019
@michael-ar
Copy link
Contributor Author

@medikoo no worries, thanks for your speedy maintenance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose new ParallelizationFactor option for Kinesis streams
4 participants