Clarifying Azure setup #7015
Merged
Clarifying Azure setup #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
Great thanks @miguel-a-calles-mba for picking this up!
As I see CI fails, as updated document doesn't match Prettier formatting. Can you run npm run prettify-updated to fix it?
|
Sorry about that. I prettified the file. |
medikoo
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
Updated the documentation to make it more clear.
Closes #N/A
How can we verify it
Run through the procedure.
Todos
Useful Scripts
npm run test-ci--> Run all validation checks on proposed changesnpm run lint-updated--> Lint all the updated filesnpm run lint:fix--> Automatically fix lint problems (if possible)npm run prettier-check-updated--> Check if updated files adhere to Prettier confignpm run prettify-updated--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: NO