New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove $context.status
from websocket access log format
#7014
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7014 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 229 229
Lines 8416 8416
=======================================
Hits 7447 7447
Misses 969 969
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sammarks !
Is there any workaround in the meantime ? |
@leclercb I’ve just updated my package.json to point to my fork directly until we get a new release with the fix included. Or since it’s merged into master now you can just update yours to point to the master branch instead of a specific version. |
$context.status
from websocket access log format$context.status
from websocket access log format
Is this gonna be released soon? This this blocking all deployments, and since we use Github Actions, we can't change the package.json |
Sorry for delay. It'll be released first thing tomorrow CET morning. |
What did you implement
It looks like AWS may have recently introduced a change where
$context.status
is invalid on API Gateway WebSocket APIs (or at least now they're enforcing invalid tokens).This change simply removes the offending token from the WebSocket log format so WebSocket APIs will deploy properly.
How can we verify it
Create a WebSocket-based service.
Todos
Useful Scripts
npm run test-ci
--> Run all validation checks on proposed changesnpm run lint-updated
--> Lint all the updated filesnpm run lint:fix
--> Automatically fix lint problems (if possible)npm run prettier-check-updated
--> Check if updated files adhere to Prettier confignpm run prettify-updated
--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: NO