Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authorizer type check from #6150 case insensitive #7001

Merged
merged 1 commit into from Nov 25, 2019

Conversation

zoellner
Copy link
Contributor

What did you implement

Minor addition to #6150 to make authorizer type check case insensitive

How can we verify it

same as #6150

Todos

  • Write and run all tests N/A
  • Write documentation N/A
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov-io
Copy link

Codecov Report

Merging #7001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7001   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         229      229           
  Lines        8417     8417           
=======================================
  Hits         7445     7445           
  Misses        972      972
Impacted Files Coverage Δ
...pile/events/apiGateway/lib/method/authorization.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03759e4...e8b22d8. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zoellner !

@medikoo medikoo merged commit e3097bc into serverless:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants