Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment bucket SSE documentation #7000

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 22, 2019

Regression introduced with #6547

If we set serverSideEncryption to true, then deployment will fail with:

 ServerlessError: Expected params.ServerSideEncryption to be a string
      at /Users/medikoo/npm-packages/serverless/lib/plugins/aws/provider/awsProvider.js:317:27
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at runNextTicks (internal/process/task_queues.js:62:3)
      at processImmediate (internal/timers.js:412:9)
      at process.topLevelDomainCallback (domain.js:130:23)

It's expected to be encryption method.

It's also documented that way on AWS services page: https://github.com/serverless/serverless/blob/9a81af586f04ea9d4ea1fb38f44eec565d9b0365/docs/providers/aws/guide/services.md#serverlessyml

@medikoo medikoo added this to the 1.59.0 milestone Nov 22, 2019
@medikoo medikoo self-assigned this Nov 22, 2019
@medikoo medikoo requested a review from astuyve November 22, 2019 16:55
@codecov-io
Copy link

Codecov Report

Merging #7000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7000   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         229      229           
  Lines        8417     8417           
=======================================
  Hits         7445     7445           
  Misses        972      972

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a81af5...1190827. Read the comment docs.

Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number 7000!!!

@medikoo medikoo merged commit 03759e4 into master Nov 22, 2019
@medikoo medikoo deleted the fix-deployment-bucket-doc branch November 22, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants