Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup and refactoring #6990

Merged
merged 3 commits into from Nov 21, 2019
Merged

Conversation

chocnut
Copy link
Contributor

@chocnut chocnut commented Nov 21, 2019

Simplifying code and improve function parameters style.

  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #6990 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6990      +/-   ##
==========================================
- Coverage   88.43%   88.43%   -0.01%     
==========================================
  Files         229      229              
  Lines        8420     8419       -1     
==========================================
- Hits         7446     7445       -1     
  Misses        974      974
Impacted Files Coverage Δ
lib/utils/downloadTemplateFromRepo.js 96.22% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05eec83...2c1944e. Read the comment docs.

@medikoo medikoo added this to the 1.59.0 milestone Nov 21, 2019
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @chocnut ! Thank you

@medikoo medikoo merged commit c77cf01 into serverless:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants