New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for best practices on CI/CD #6988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skierkowski it's still at Draft stage. Is it intentional?
…erless into docs-cicd-workflow-guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍
I just reverted the formatting @medikoo mentioned in the other PR review. For some reason my Prettier also formats the code this way on my local machine (alongside other files).
Anyway, let's wait until the linked page is live. @skierkowski would be nice if you could ping us again so we can do a final review and merge 👍
Codecov Report
@@ Coverage Diff @@
## master #6988 +/- ##
==========================================
+ Coverage 88.48% 88.49% +<.01%
==========================================
Files 229 229
Lines 8416 8423 +7
==========================================
+ Hits 7447 7454 +7
Misses 969 969
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What did you implement
Adding a new page to the CI/CD docs to reference the new workflow guide.
How can we verify it
(adding preview page soon)