Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for best practices on CI/CD #6988

Merged
merged 6 commits into from Dec 3, 2019
Merged

Conversation

skierkowski
Copy link
Member

What did you implement

Adding a new page to the CI/CD docs to reference the new workflow guide.

How can we verify it

(adding preview page soon)

@skierkowski skierkowski reopened this Nov 22, 2019
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skierkowski it's still at Draft stage. Is it intentional?

lib/plugins/aws/package/compile/functions/index.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍

I just reverted the formatting @medikoo mentioned in the other PR review. For some reason my Prettier also formats the code this way on my local machine (alongside other files).

Anyway, let's wait until the linked page is live. @skierkowski would be nice if you could ping us again so we can do a final review and merge 👍

@codecov-io
Copy link

Codecov Report

Merging #6988 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6988      +/-   ##
==========================================
+ Coverage   88.48%   88.49%   +<.01%     
==========================================
  Files         229      229              
  Lines        8416     8423       +7     
==========================================
+ Hits         7447     7454       +7     
  Misses        969      969
Impacted Files Coverage Δ
...aws/package/compile/events/websockets/lib/stage.js 100% <0%> (ø) ⬆️
lib/plugins/aws/metrics/awsMetrics.js 100% <0%> (ø) ⬆️
...plugins/aws/package/compile/events/stream/index.js 98.78% <0%> (+0.03%) ⬆️
lib/plugins/aws/provider/awsProvider.js 90.79% <0%> (+0.03%) ⬆️
lib/plugins/aws/logs/index.js 94.11% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c6c8d...9350eb1. Read the comment docs.

@skierkowski skierkowski marked this pull request as ready for review December 3, 2019 06:00
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medikoo medikoo merged commit 677afd1 into master Dec 3, 2019
@medikoo medikoo added this to the 1.59.0 milestone Dec 3, 2019
@medikoo medikoo deleted the docs-cicd-workflow-guide branch December 3, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants