Fix deploy command if package.individually set on a function-level

[mthenw]

What did you implement:

Closes #6120

The issue was that sls deploy didn't work if package.individually was set on a function-level. According to the docs, it should work but looks like it has never worked.

How did you implement it:

I simplified & cleaned up the validation logic that runs before deployment.

How can we verify it:

I gave two examples in the comment: #6120 (comment). Both works now.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

• Write tests and confirm existing functionality is not broken.
  Validate via npm test
• Write documentation
• Ensure there are no lint errors.
  Validate via npm run lint-updated
  Note: Some reported issues can be automatically fixed by running npm run lint:fix
• Ensure introduced changes match Prettier formatting.
  Validate via npm run prettier-check-updated
  Note: All reported issues can be automatically fixed by running npm run prettify-updated
• Make sure code coverage hasn't dropped
• Provide verification config / commands / resources
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

[dschep]

Happy Birthday Maciej!!!

[mthenw]

Looks like it's failing on prettier but works for me locally

➜  serverless (master) ✔ npm run prettier-check-updated

> serverless@1.49.0 prettier-check-updated /Users/maciej.winnicki/Projects/serverless
> pipe-git-updated --ext=css --ext=html --ext=js --ext=json --ext=md --ext=yaml --ext=yml -- prettier -c

:thonk:

[mthenw]

Oh, and thanks @dschep :D

[dschep]

try..

rm -rf package-lock.json node_modules
npm i
npm run prettify

[mthenw]

@dschep I fixed it. Thanks!

[medikoo]

@mthenw looks as notable fix :)

Just one minor remark, and I think it'll be good to accompany this with some test, to avoid eventual regression

[medikoo]

If I read correctly, it'll change behavior for configurations in which both package.individually and package.artifact is set.

Such configuration is obviously contradictory, still currentlypackage.individually takes precedence over package.artifact, and effect of this PR would be that this precedence will be reverted.

I think it'll be better if we maintain precedence of package.individually

[mthenw]

Good catch! Let me fix it.

[mthenw]

@medikoo I'm not super happy about that assertion so please let me know if there are better ways to check it

[medikoo]

Probably better would be to just confirm that awsDeploy.extendedValidate doesn't crash with individually set on function level (which I believe will happen on master now)

[mthenw]

Done!

[medikoo]

Thank you @mthenw! It sneaks with last boarding call into v1.50.0 :)