Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GITHUB-6525-5172): Rewrite copyDirContentsSyncAllow to call fs-extra::copySync() on the directories instead of calling it on the files to copy individually #6526

Merged
merged 1 commit into from
Aug 13, 2019
Merged

fix(GITHUB-6525-5172): Rewrite copyDirContentsSyncAllow to call fs-extra::copySync() on the directories instead of calling it on the files to copy individually #6526

merged 1 commit into from
Aug 13, 2019

Commits on Aug 12, 2019

  1. fix(GITHUB-6525-5172): Rewrite copyDirContentsSyncAllow to call fs-ex… 

    …tra::copySync() on the directories instead of calling it on the files to copy individually.

The main motivation behind these changes is to rely on
https://github.com/jprichardson/node-fs-extra/blob/8.1.0/docs/copy-sync.md as
much as possible in order to avoid having to do the
`fullFilePath.replace(srcDir, '')` operation because this operation can be
error-prone.

Doing so fixes the following issues because the user-submitted file paths are
now correctly interpreted by fs-extra, closing both serverless#6525 and serverless#5172.
    @stephaneseng
    stephaneseng committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    5952712 View commit details
    Browse the repository at this point in the history