Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for EventBridge partner event sources #6518

Merged
merged 1 commit into from Aug 9, 2019

Conversation

pmuens
Copy link
Contributor

@pmuens pmuens commented Aug 8, 2019

What did you implement:

Closes #6514

Fixes support for EventBridge partner event sources.

How did you implement it:

Fix the arn parser.

How can we verify it:

See service config posted in the issue.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens requested a review from medikoo August 9, 2019 11:51
@pmuens pmuens force-pushed the event-bridge-partner-events branch from 601369f to 26cc941 Compare August 9, 2019 11:52
@pmuens pmuens force-pushed the event-bridge-partner-events branch from 26cc941 to 21f4f7f Compare August 9, 2019 12:40
@pmuens pmuens requested a review from medikoo August 9, 2019 12:40
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmuens pmuens merged commit 8a82c8a into master Aug 9, 2019
@pmuens pmuens deleted the event-bridge-partner-events branch August 9, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon EventBridge not compatible with partner event sources
2 participants