Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeless guide docs #6513

Merged
merged 2 commits into from Aug 8, 2019
Merged

Update kubeless guide docs #6513

merged 2 commits into from Aug 8, 2019

Conversation

MPratley
Copy link
Contributor

@MPratley MPratley commented Aug 7, 2019

What did you implement:

Added documentation on using kubeless with custom Ingress Controllers and adding annotations.

How did you implement it:

Updated the example serverless.yml at the top of the guide, and added a fleshed out section further down.

How can we verify it:

Proofread the docs and check it largely makes sense.

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Add the docs for ingress.name param Adds support for separate ingress class and ingress names. serverless-kubeless#181
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

MPratley and others added 2 commits August 7, 2019 14:46
Info about custom ingress classes and annotations.
Copy link

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for updating @MPratley 👍

@pmuens pmuens merged commit 419dae8 into serverless:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants