Remove Enterprise and Platform from log info #6501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschep
previously approved these changes
Aug 5, 2019
| @@ -330,7 +330,7 @@ class CLI { | |||
|
|
|||
| getVersionNumber() { | |||
| this.consoleLog( | |||
| `${version} (Enterprise Plugin: ${enterpriseVersion}, Platform SDK: ${sdkVersion})` | |||
| `Framework Core: ${version}\nPlugin: ${enterpriseVersion}\nSDK: ${sdkVersion}\n` | |||
There was a problem hiding this comment.
Hmm.. seems a bit to ambiguous now thb... what about Dashboard Plugin and Dashboard SDK?
There was a problem hiding this comment.
I think the preference is to leave it somewhat ambiguous, in order to keep things more future-proof.
There was a problem hiding this comment.
I agree here 🤔
What if we use the npm package names?
serverless: 1.49.0
@serverless/enterprise-plugin: 1.2.3
@serverless/platform-sdk: 1.2.3
pmuens
approved these changes
Aug 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Removed
EnterpriseandPlatformfrom loglineHow did you implement it:
With the
deletekey.How can we verify it:
run
serverless -vagainst this branch, or require this class in a node console and rungetVersionNumber()Todos:
Note: Run
npm run test-cito run all validation checks on proposed changesValidate via
npm testValidate via
npm run lint-updatedNote: Some reported issues can be automatically fixed by running
npm run lint:fixValidate via
npm run prettier-check-updatedNote: All reported issues can be automatically fixed by running
npm run prettify-updatedIs this ready for review?: YES
Is it a breaking change?: NO