Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render event information in aws-ruby handler template #6478

Merged
merged 1 commit into from Jul 31, 2019

Conversation

ktopolski
Copy link
Contributor

What did you implement:

Enhanced aws-ruby handler template to render event information in response JSON, just like aws-nodejs template does.

Closes #6462

How did you implement it:

Changed handler.rb to render event information under input key in body - just like in aws-nodejs template. Also - ditched JSON.generate in favor of to_json, since JSON.generate is invalid syntax till ruby-2.4.0 and it may be discouraging for new people.

How can we verify it:

$ bin/serverless -t aws-ruby --path test
$ cd test
$ serverless deploy # given aws configured
$ curl -X GET url-gained-from-previous-output

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktopolski 👍

LGTM :shipit:

@pmuens pmuens merged commit 4327725 into serverless:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby template
2 participants