Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation tweak around shared authorizers #5944

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

stuartsan
Copy link
Contributor

@stuartsan stuartsan commented Mar 20, 2019

What did you implement:

Documentation tweak to note that shared authorizers of type REQUEST are also fine

How did you implement it:

How can we verify it:

Per CloudFormation docs, which are referenced in the existing docs here:

The type of authorizer. Valid values include:
TOKEN: A custom authorizer that uses a Lambda function.
COGNITO_USER_POOLS: An authorizer that uses Amazon Cognito user pools.
REQUEST: An authorizer that uses a Lambda function using incoming request parameters.

And per #4325, it appears that REQUEST type authorizers are supported by serverless generally

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Authorizers of type REQUEST are also fine
@pmuens pmuens self-assigned this Mar 21, 2019
@pmuens pmuens added this to the 1.40.0 milestone Mar 21, 2019
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @stuartsan 👍

LTGM :shipit:

@pmuens pmuens merged commit 315320f into serverless:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants