New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle layers paths with trailing slash and leading ./ or just . #5656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @dschep 🤘
Could you add some unit tests? After that it should be GTM !
There is more going on than just a bug with railing slashes check: |
@khalilgharbaoui, yup. I've noticed, just slow moving on this PR cause I've had other things on my plate. It's updated now and should handle that case too. Do you mind testing it? |
@pmuens, reworked the implementation and added tests for the new way of fixing this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating @dschep 👍
Can conform that this works on my machine! LGTM
Working perfect now! |
What did you implement:
handle layers paths with trailing slash
closes #5646
How did you implement it:
use
path.resolve
on the layer path before using it as a prefixHow can we verify it:
create a service with a layer with a path ending in
/
Todos:
Write documentationIs this ready for review?: YES
Is it a breaking change?: NO