Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uploaded file name to log while AWS deploy #5495

Merged
merged 2 commits into from Jan 23, 2019
Merged

Add uploaded file name to log while AWS deploy #5495

merged 2 commits into from Jan 23, 2019

Conversation

Enase
Copy link
Contributor

@Enase Enase commented Nov 15, 2018

What did you implement:

Closes #5358

Add uploaded filename to console while while uploading services

How did you implement it:

Filename added to console output

Examples:
see #5358

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@eliliam eliliam mentioned this pull request Nov 16, 2018
Closed
pmuens
pmuens previously approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for working on this @Enase 👍

I think it should be GTM once the conflicts are resolved.

@pmuens pmuens self-assigned this Jan 23, 2019
pmuens
pmuens approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the conflicts. Merging... :shipit:

@pmuens pmuens merged commit 3c5e5a2 into serverless:master Jan 23, 2019
@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees

@pmuens pmuens

Labels
enhancement
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enase @pmuens @shortjared