Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix mismatch in AWS Metrics #5276

Merged
merged 1 commit into from Sep 9, 2018
Merged

[docs] Fix mismatch in AWS Metrics #5276

merged 1 commit into from Sep 9, 2018

Conversation

andriyor
Copy link
Contributor

@andriyor andriyor commented Sep 5, 2018

What did you implement:

Update AWS Metrics documentation about startTime option.

How did you implement it:

Minor update to AWS Metrics docs

How can we verify it:

Check the docs.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

horike37
horike37 approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andriyor
Thanks! That was a typo 😓
Nice catch!

@horike37 horike37 merged commit 9f1c334 into serverless:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horike37 horike37 horike37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andriyor @horike37