Fix for #3069 - Failing to handle schedule event body params due to f… #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailures in stringifying an already stringified...string.
horike37
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
It works as expected 👍 Sweat!
Thank you for you contribution @shanehandley 💯
merging...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ailures in stringifying an already stringified...string.
What did you implement:
Closes #3069
How did you implement it:
The author of the bug has a good description of the issue seen.
During processing of the Input body, first checking if it is a string, then parsing it to JSON so it is provided correctly to the scheduleTemplate as valid JSON.
How can we verify it:
Clone my fix test, which uses the reporters example:
git@github.com:shanehandley/serverless-fix-3069.gitInstall:
npm installExecute:
./node_modules/serverless/bin/serverless packageThe packaging should complete without error.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO