Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new template for AWS Alexa Typescript #5266

Merged
merged 3 commits into from Sep 4, 2018
Merged

Add new template for AWS Alexa Typescript #5266

merged 3 commits into from Sep 4, 2018

Conversation

danielrbradley
Copy link

@danielrbradley danielrbradley commented Aug 31, 2018

What did you implement:

Added a template for building Alexa skills, based on the serverless-alexa-skills plugin.

How did you implement it:

Adapted from the existing aws-nodejs-typescript template:

  • Added the serverless-alexa-skills plugin.
  • Added the ask-sdk package.
  • Adapted the handler for Alexa.
  • Added matching unit and integration tests.

How can we verify it:

  1. Run the additional unit and integration tests.
  2. Setup a new project using: sls create --template-url https://github.com/danielrbradley/serverless/tree/alexa-typescript-template/lib/plugins/create/templates/aws-alexa-typescript
  3. Follow the instructions in the generated serverless.yml (you'll need an Amazon developer account)

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: NO

- Adapt from `aws-nodejs-typescript`.
- Tested manually by specifying template-url.
- Add unit and integration tests for new create template.
- Waiting on the next version of the `serverless-alexa-skills` plugin to be released on NPM.
- Ensure we restore the version that’s compatible with the instructions.
- Update instructions to remove manual vendor configuration.
@danielrbradley
Copy link
Author

Hi @horike37 the new version of the plugin has just been released, so this should be ready for review now. Thanks 🙂

@horike37
Copy link
Member

horike37 commented Sep 3, 2018

Thank you for pinging @danielrbradley !
Will review this as soon as possible 👍

Copy link
Member

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrbradley
Just tested and it works like a charm! Awesome 💯 😄
The code looks good from my view.
You might want to add this to the following some template lists as well. We can merge if it will be done 👍

  • docs/providers/aws/cli-reference/create.md
  • docs/providers/aws/guide/services.md

@horike37 horike37 added this to the 1.31.0 milestone Sep 4, 2018
@danielrbradley
Copy link
Author

@horike37 good spot - I've pushed an update for those two pages.

Happy to be able to contribute 😊Keep up the good work 👍

Copy link
Member

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrbradley
Thank you for the updates 👍 It's perfect!

Happy to be able to contribute 😊Keep up the good work 👍

Glad to hear that. Hope you enjoy contributions 😄

@horike37 horike37 merged commit 962f093 into serverless:master Sep 4, 2018
@danielrbradley danielrbradley deleted the alexa-typescript-template branch September 5, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants