New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new template for AWS Alexa Typescript #5266
Add new template for AWS Alexa Typescript #5266
Conversation
- Adapt from `aws-nodejs-typescript`. - Tested manually by specifying template-url. - Add unit and integration tests for new create template. - Waiting on the next version of the `serverless-alexa-skills` plugin to be released on NPM.
- Ensure we restore the version that’s compatible with the instructions. - Update instructions to remove manual vendor configuration.
Hi @horike37 the new version of the plugin has just been released, so this should be ready for review now. Thanks 🙂 |
Thank you for pinging @danielrbradley ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielrbradley
Just tested and it works like a charm! Awesome 💯 😄
The code looks good from my view.
You might want to add this to the following some template lists as well. We can merge if it will be done 👍
- docs/providers/aws/cli-reference/create.md
- docs/providers/aws/guide/services.md
@horike37 good spot - I've pushed an update for those two pages. Happy to be able to contribute 😊Keep up the good work 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielrbradley
Thank you for the updates 👍 It's perfect!
Happy to be able to contribute 😊Keep up the good work 👍
Glad to hear that. Hope you enjoy contributions 😄
What did you implement:
Added a template for building Alexa skills, based on the
serverless-alexa-skills
plugin.How did you implement it:
Adapted from the existing
aws-nodejs-typescript
template:serverless-alexa-skills
plugin.ask-sdk
package.How can we verify it:
sls create --template-url https://github.com/danielrbradley/serverless/tree/alexa-typescript-template/lib/plugins/create/templates/aws-alexa-typescript
serverless.yml
(you'll need an Amazon developer account)Todos:
Is this ready for review?: Yes
Is it a breaking change?: NO