Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API Gateway Default Request Templates #5222

Merged
merged 1 commit into from Sep 4, 2018

Conversation

mikelax
Copy link
Contributor

@mikelax mikelax commented Aug 16, 2018

Update the list available attributes available in the default API Gateway Request Templates.

NOTE I also think that method should be httpMethod or mentioned it's in the requestContext

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Update the list available attributes available in the default API Gateway Request Templates. 

*NOTE* I also _think_ that `method` should be `httpMethod` or mentioned its in the `requestContext`
Copy link
Member

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikelax
Good catch 👍 Thank you for your first-time contribution!

@horike37 horike37 merged commit 09a1c24 into serverless:master Sep 4, 2018
@mikelax mikelax deleted the patch-1 branch September 4, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants