Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /tmp/node-dependencies* #5079

Merged

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Jun 27, 2018

What did you implement:

Since node-dependencies* will remain in /tmp, cleanup added.

How did you implement it:

Add the flow to be deleted last.

How can we verify it:

File does not remain in /tmp after deploy.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Because `node-dependencies-*` remains below `/tmp/`
@horike37
Copy link
Member

Hi @abetomo, Thank you for your first-time contribution on this repo 👍
When does this happen? I would like to know how to reproduce it so that I can test and review it properly.

@abetomo
Copy link
Contributor Author

abetomo commented Aug 14, 2018

@horike37 Thank you for review.
As described below, when you deploy, files are created in the /tmp.
Because it is not deleted automatically, the number of files increases.

% ls /tmp/node-dependencies*
zsh: no matches found: /tmp/node-dependencies*
% serverless deploy -s production function -f FUNCTION
...
% ls -lh /tmp/node-dependencies*
-rw-r--r-- 1 vagrant vagrant 25K Aug 14 10:07 /tmp/node-dependencies-76deac41969e904e-dev
-rw-r--r-- 1 vagrant vagrant  38 Aug 14 10:07 /tmp/node-dependencies-76deac41969e904e-prod

% serverless deploy -s production
...
% ls -lh /tmp/node-dependencies*
-rw-r--r-- 1 vagrant vagrant 25K Aug 14 10:19 /tmp/node-dependencies-5a3a322da5f3c0b2-dev
-rw-r--r-- 1 vagrant vagrant  38 Aug 14 10:19 /tmp/node-dependencies-5a3a322da5f3c0b2-prod
-rw-r--r-- 1 vagrant vagrant 25K Aug 14 10:07 /tmp/node-dependencies-76deac41969e904e-dev
-rw-r--r-- 1 vagrant vagrant  38 Aug 14 10:07 /tmp/node-dependencies-76deac41969e904e-prod

Copy link
Member

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the response @abetomo 👍
Umm, I tried it again but it was not reproduced.

My guess is this may depends on each enviroments. This PR would not introduce any side effect, so I will merge it once and see how it goes after the next release.

@horike37 horike37 added this to the 1.31.0 milestone Sep 4, 2018
@horike37 horike37 merged commit ef7391f into serverless:master Sep 4, 2018
@abetomo
Copy link
Contributor Author

abetomo commented Sep 5, 2018

Thank you.

@abetomo abetomo deleted the feature_unlink_tmp_node_dependencies branch September 5, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants