Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tab completion for slss shortcut #4712

Merged
merged 1 commit into from Jan 23, 2019
Merged

Enable tab completion for slss shortcut #4712

merged 1 commit into from Jan 23, 2019

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Feb 3, 2018 •
edited

What did you implement:

Closes #4671

How did you implement it:

How can we verify it:

Todos:

  • Make sure code coverage hasn't dropped
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

pmuens
pmuens approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for adding this @drexler 👍

LGTM :shipit:

@pmuens pmuens changed the title enable tab completion for slss shortcut Enable tab completion for slss shortcut Jan 23, 2019
@pmuens pmuens self-assigned this Jan 23, 2019
eahefnawy
eahefnawy approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drexler ... and sorry for the very late response.

We're prepping a patch release right now, and we will merge this after.

@pmuens pmuens merged commit 90717e0 into serverless:master Jan 23, 2019
@pmuens pmuens added this to the 1.36.4 milestone Feb 5, 2019
@Gerst20051
Copy link

it's funny how this was merged in yet still no resolution to being able to disable tab tab autocompletions from being installed

@Gerst20051 Gerst20051 mentioned this pull request Feb 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

@eahefnawy eahefnawy eahefnawy approved these changes

Assignees

@pmuens pmuens

Labels
enhancement
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@drexler @Gerst20051 @pmuens @eahefnawy @horike37 @shortjared