fix(model): properly serialize WHERE attributes in soft delete (#8383)

sequelize · Sep 29, 2017 · ba7aa33 · ba7aa33
1 parent 107502e
commit ba7aa33
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/model.js b/lib/model.js
@@ -3788,7 +3788,7 @@ class Model {
         this.setDataValue(field, values[field]);
 
         return this.sequelize.getQueryInterface().update(
-          this, this.constructor.getTableName(options), values, where, _.defaults({ hooks: false }, options)
+          this, this.constructor.getTableName(options), values, where, _.defaults({ hooks: false, model: this.constructor }, options)
         ).then(results => {
           const rowsUpdated = results[1];
           if (this.constructor._versionAttribute && rowsUpdated < 1) {

diff --git a/test/integration/instance.test.js b/test/integration/instance.test.js
@@ -2100,6 +2100,32 @@ describe(Support.getTestDialectTeaser('Instance'), () => {
         });
       });
     });
+
+    if (dialect.match(/^postgres/)) {
+      it('converts Infinity in where clause to a timestamp', function() {
+        const Date = this.sequelize.define('Date',
+          {
+            date: {
+              type: DataTypes.DATE,
+              primaryKey: true
+            },
+            deletedAt: {
+              type: DataTypes.DATE,
+              defaultValue: Infinity
+            }
+          },
+          { paranoid: true });
+
+        return this.sequelize.sync({ force: true })
+          .then(() => {
+            return Date.build({ date: Infinity })
+              .save()
+              .then(date => {
+                return date.destroy();
+              });
+          });
+      });
+    }
   });
 
   describe('isSoftDeleted', () => {