Add filename ignore pattern for match-exports rule

[avaly]

This adds an additional option to the match-exports rule: a filename ignore pattern.

If you prefer to use suffixes for your files (e.g. Foo.react.js for a React component file), you can use the following configuration:

"filenames/match-exported": [2, "", "\\.react"]

[coveralls]

Coverage remained the same at 100.0% when pulling 478492c on avaly:match-exports-filename-ignore-pattern into 8bf352e on selaux:master.

[selaux]

Does this work for you: https://github.com/mradionov/eslint-plugin-disable#file-paths?

Then I will close and wait for eslint to natively support this functonality.

[avaly]

@selaux I'm not sure how that plugin is supposed to help with the functionality I'm trying to get from this PR. AFAICT that plugin allows for disabling other plugins completely. This is not what I'm looking for though.

[selaux]

Sorry, I thought you wanted to disable the whole plugin 🙁 . The thing is that this is basically a eslint inherent problem. You want to lint specific globbed files with specific rulesets, which eslint does not support yet as described in eslint/eslint#3611. I'm unsure on how to handle this to be honest as I don't want to introduce functionality that will be removed soon...

[avaly]

No, I do not want to disable the whole plugin and I don't want to lint specific globbed files with some rules.

Let's take an example from the tests in this PR, assuming the following file:

Foo.react.js:

export default class Foo {
  render() {
    return <span>Test Class</span>;
  }
}

Applying this rule with the default config of "filenames/match-exported": [2], would result in a lint error similar to: Filename 'Foo.react' must match the exported name 'Foo'.

However with the following config from this PR: "filenames/match-exported": [2, "", "\\.react"], there would be no lint error, since we strip the .react suffix from the filename before comparing with the exported name.

[avaly]

Disabling this rule for specific globbed files would not help with the following case:

Bar.react.js:

export default class Foo {
  render() {
    return <span>Test Class</span>;
  }
}

If I'd disable the filenames/match-exported rule completely for *.react.js files, then the above would not throw a lint error.

[avaly]

@selaux Any more thoughts on merging this PR?

[imevro]

@selaux ping

[selaux]

Sorry for the late response, as eslint/eslint#3611 is still a ongoing discussion which does seem to take even more time, I will merge this for now and remove it again once the respective eslint feature is merged.

[imevro]

@selaux awesome, thanks!