Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Template default branch in oss-npm-package #1336

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

72636c
Copy link
Member

@72636c 72636c commented Dec 12, 2023

Follows on from #1335.

Copy link

changeset-bot bot commented Dec 12, 2023

⚠️ No Changeset found

Latest commit: 83ccc1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -99,7 +99,7 @@ If you use the `Squash and merge` option on pull requests, take extra care to fo

### Releasing latest

Commits to the `master` branch will be released with the `latest` tag,
Commits to the `<%- defaultBranch %>` branch will be released with the `latest` tag,
Copy link
Member Author

@72636c 72636c Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantic-release/semantic-release#1581

Had to add the following, maybe we should speed up the migration to Changesets 😅

{
"branches": [
"+([0-9])?(.{+([0-9]),x}).x",
"<%- defaultBranch %>",
"next",
"next-major",
{
"name": "beta",
"prerelease": true
},
{
"name": "alpha",
"prerelease": true
}
]
}

@72636c 72636c marked this pull request as ready for review December 12, 2023 01:28
@72636c 72636c requested review from a team as code owners December 12, 2023 01:28
@72636c 72636c merged commit 60396fa into master Dec 12, 2023
19 checks passed
@72636c 72636c deleted the oss-default-branch branch December 12, 2023 01:36
72636c added a commit that referenced this pull request Dec 13, 2023
72636c added a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants