Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page loading issue #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DanilAgafonov
Copy link

@DanilAgafonov DanilAgafonov commented Mar 17, 2023

I faced the issue: TimeoutError: Waiting failed: 30000ms exceeded. It was stuck on this line:

await page.waitForFunction(`

I tried to disable headless mode and I found only one error in browser console:

Uncaught (in promise) Error: Failed to initialize Storybook.

Do you have an error in your `preview.js`? Check your Storybook's browser console for errors.

This error appears only when I use screener-storybook. I see no issue if I run Storybook normally or if I build Storybook statically, serve storybook-static dir via HTTP and open /iframe.html.

This PR offers one-line fix.

@DanilAgafonov
Copy link
Author

@sauce-tartar could please take a look?

@sauce-gabriel
Copy link
Collaborator

Hello @DanilAgafonov, thank you for reporting the issue along with a quick fix 💪
Would you be able to give me more details about how to reproduce the issue, please? (Storybook, react and node versions would be also as well)

@DanilAgafonov
Copy link
Author

Sorry for delay. It looks like it was my mistake: I didn't realize that screener-storybook is not ready for Storybook v7.

My setup includes Storybook v7 RC, @storybook/html, @storybook/html-vite (all of them 7.0.0-rc.5).

I finally managed to make screener-storybook work with my setup. In order to do that, I:

I think it is safe to close this PR for now. But if you are planning to support Storybook v7 with storyStoreV7 enabled, you probably have to introduce this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants