Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request version to avoid npm warn #1915

Merged
merged 2 commits into from Feb 27, 2017
Merged

Conversation

arzafran
Copy link
Contributor

@arzafran arzafran commented Feb 24, 2017

Background

request 2.78.0 uses deprecated node-uuid, it has been updated in version 2.79.0 to use uuid package, an unwanted warn is shown in the console when npm installing node-sass

Changes done

bump request dependency version to 2.79.0

## Background
_request 2.78.0 uses deprecated node-uuid, it has been updated in version 2.79.1 to use uuid package, an unwanted warn is shown in the console when npm installing node-sass_
## Changes done
_bump request dependency version to 2.79.1_
@nschonni
Copy link
Contributor

Because of the ^, that is the version that should be installed anyway. I do understand trying to bump it up though to avoid a known issue

@arzafran
Copy link
Contributor Author

arzafran commented Feb 24, 2017

@nschonni It should work like that, but in several environments at my office we had this warn shown because of old dependency being installed when doing an npm install and it's a really minor change that would solve the issue

@danez
Copy link
Contributor

danez commented Feb 27, 2017

It can sometimes happen that an other dependency depends on request version <2.79 && >2.61. And if this dependency gets resolved before node-sass, npm will use the older version of request also for node-sass as it also satisfies the dependency ^2.61

@xzyfer
Copy link
Contributor

xzyfer commented Feb 27, 2017

Apologies, I've been away. I agree with @nschonni that this isn't technically necessary but I also see how much people react to these messages - fsevents/fsevents#163

Thanks @arzafran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants