Skip to content

Commit

Permalink
Bump request@2.87.0
Browse files Browse the repository at this point in the history
As of 2.87.0 the hoek packages has been removed which restores
Node < 4 support
  • Loading branch information
xzyfer committed Jul 5, 2018
1 parent 62fd84a commit ef713a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -1,8 +0,0 @@
<!--
**Do not bump the Request package, it breaks old Node compatiblity. It is used for downloading the binaries.**
Follow https://github.com/sass/node-sass/issues/2355 for updates on when that will be resolved.
Thanks for contibuting otherwise!
-->
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -68,13 +68,13 @@
"nan": "^2.10.0",
"node-gyp": "^3.3.1",
"npmlog": "^4.0.0",
"request": "~2.79.0",
"request": "2.87.0",

This comment has been minimized.

Copy link
@realityking

realityking Jul 5, 2018

Contributor

Did you intentionally not use the caret operator here?

This comment has been minimized.

Copy link
@xzyfer

xzyfer Jul 5, 2018

Author Contributor

Yes. Request has shown a disregard for breaking Node support and they do test Node < 4 in CI. We are not will to risk another breaking in support.

"sass-graph": "^2.2.4",
"stdout-stream": "^1.4.0",
"true-case-path": "^1.0.2"
},
"devDependencies": {
"coveralls": "^2.11.8",
"coveralls": "^3.0.2",
"eslint": "^3.4.0",
"fs-extra": "^0.30.0",
"istanbul": "^0.4.2",
Expand Down

0 comments on commit ef713a7

Please sign in to comment.