Skip to content

Commit

Permalink
Workaround waiting for AppVeyor to add Node versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@xzyfer
xzyfer committed Apr 26, 2019
1 parent 9e564a1 commit 12c0052
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions appveyor.yml
View file
Expand Up @@ -78,7 +78,8 @@
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017

install:
- ps: Install-Product node $env:nodejs_version $env:platform
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
- node --version
- npm --version
- npm install
Expand Down Expand Up @@ -174,7 +175,8 @@
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017

install:
- ps: Install-Product node $env:nodejs_version $env:platform
# https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
- node --version
- npm --version
- npm install
Expand Down

3 comments on commit 12c0052

@XhmikosR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xzyfer @nschonni: just a reminder that this should be reverted when AppVeyor has Node.js 12. Because if not, when Node.js 13 is out it'll use that.

@xzyfer
Copy link
Contributor Author

@xzyfer xzyfer commented on 12c0052 Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that true? What's the point of the node_version substitution?

@XhmikosR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, didn't see you had added the environment variable in another commit.

All good then, but still I'd personally just remove this when Node.js 12 is added on AppVeyor, but maybe that's only me . I mean on the other hand this ensures you are always getting the latest Node.js release of the specified versions, so it's good that way.

Please sign in to comment.