Undeprecate CSS imports in 3.5 #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2615 as it landed in 3.5. It will also be removed in master.
See sass/node-sass#2362 for additional context on this back flip.
This was added as a first step to removing support for raw CSS
@imports. However it appears that CSS @imports are a highly valuedfeature among the current Sass community. Without a viable way
to resolve the deprecation warning AND keep the desired behaviour
we've decided to remove the blanket deprecation warning and restore
the old behaviour.
In the near future we will be introducing a new deprecation warning
when an
@import'ed CSS file uses Sass language features.Additionally this removes the C-API
sass_option_push_import_extensionwhich was added a work around to ease the transition for implementors.
cc @asottile as an early heads up (very sorry for the churn!).